Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pynitrokey: 0.4.47 -> 0.4.48 #326251

Closed
wants to merge 1 commit into from

Conversation

frogamic
Copy link
Contributor

@frogamic frogamic commented Jul 11, 2024

Description of changes

Release notification: https://github.com/Nitrokey/pynitrokey/releases/tag/v0.4.48
Related PRs:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from RaitoBezarius July 11, 2024 07:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 11, 2024
@natsukium
Copy link
Member

@ofborg build python312Packages.pynitrokey

@frogamic
Copy link
Contributor Author

frogamic commented Jul 16, 2024

@999eagle @panicgh this will break nitrokey-app2 builds as it exceeds the maximum version specified in requirements

@999eagle
Copy link
Contributor

we can probably just relax the version of the dependency in nitrokey-app2 given that there are very little changes in pynitrokey.

@frogamic frogamic closed this Jul 18, 2024
@frogamic frogamic deleted the pynitrokey-0.4.48 branch July 18, 2024 15:00
@frogamic
Copy link
Contributor Author

Superseded by 0.4.49: #328197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants