llvmPackages.bolt: init at 19.0.0-unstable-2024-07-08

[RossComputerGuy]

Description of changes

Continue from #289587, fixes #176536

Init LLVM's bolt onto the git version because of llvm/llvm-project#97130, we can backport once the upstream PR is merged.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pwaller]

I see only .a archive files in the lib directory. I think these should live in the dev output rather than the lib output, otherwise they end up being depended on by the bin (in this case out) output via $out/nix-support/propagated-build-inputs even though they're not needed.

There would be some care needed however to keep the libbolt_rt*.a in the same tree as bolt so it can find them.

This is handled in multiple-outputs.sh:

nixpkgs/pkgs/build-support/setup-hooks/multiple-outputs.sh

Line 183 in 1db1e3c

_multioutPropagateDev() {

Here's what I currently see, and propagated-build-inputs contains /nix/store/7d04yb047wzmyr832slq50l2k7y7rn46-bolt-19.0.0-unstable-2024-07-08-lib.

/nix/store/7d04yb047wzmyr832slq50l2k7y7rn46-bolt-19.0.0-unstable-2024-07-08-lib
└── lib
    ├── libLLVMBOLTCore.a
    ├── libLLVMBOLTPasses.a
    ├── libLLVMBOLTProfile.a
    ├── libLLVMBOLTRewrite.a
    ├── libLLVMBOLTRuntimeLibs.a
    ├── libLLVMBOLTTargetAArch64.a
    ├── libLLVMBOLTTargetRISCV.a
    ├── libLLVMBOLTTargetX86.a
    └── libLLVMBOLTUtils.a
/nix/store/4l8sg5jq9vjnf112n910k46m5dr19i62-bolt-19.0.0-unstable-2024-07-08
├── bin
│   ├── llvm-bolt
│   ├── llvm-boltdiff
│   ├── llvm-bolt-heatmap
│   ├── merge-fdata
│   └── perf2bolt
├── lib
│   ├── libbolt_rt_hugify.a
│   └── libbolt_rt_instr.a
└── nix-support
    └── propagated-build-inputs

[RossComputerGuy]

I see only .a archive files in the lib directory. I think these should live in the dev output rather than the lib output, otherwise they end up being depended on by the bin (in this case out) output via $out/nix-support/propagated-build-inputs even though they're not needed.

Yeah, I agree. Only got this PR to a buildable state, now we can make these kinds of fine adjustments 😸.

[RossComputerGuy]

Had to keep libbolt_rt_hugify.a and libbolt_rt_instr.a since they're needed at runtime.

[djacu]

Result of nixpkgs-review pr 326240 run on x86_64-linux 1

2 packages built:

• bolt_19
• bolt_19.dev