Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: 2.80.3 -> 2.80.4 #325940

Merged
merged 1 commit into from
Jul 17, 2024
Merged

glib: 2.80.3 -> 2.80.4 #325940

merged 1 commit into from
Jul 17, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 9, 2024 •
edited
Loading

Changes: https://gitlab.gnome.org/GNOME/glib/-/releases/2.80.4

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

jtojnar
jtojnar approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay. AFAICT, the Darwin patch is not in this version but 🤷‍♀️

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jul 10, 2024
@7c6f434c 7c6f434c merged commit 33531b8 into NixOS:staging Jul 17, 2024
36 checks passed
@trofi trofi deleted the glib-update branch July 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@dasj19 dasj19 Awaiting requested review from dasj19

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trofi @jtojnar @7c6f434c @wegank