Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ukmm: 0.11.1 -> 0.12.1 #325139

Merged
merged 2 commits into from
Jul 15, 2024
Merged

ukmm: 0.11.1 -> 0.12.1 #325139

merged 2 commits into from
Jul 15, 2024

Conversation

kira-bruneau
Copy link
Contributor

Description of changes

https://github.com/NiceneNerd/UKMM/releases/tag/v0.12.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@symphorien
Copy link
Member

fails to run for me (I'm on x11)

$  results/ukmm/bin/ukmm 
thread 'main' panicked at /build/cargo-vendor-dir/xkbcommon-dl-0.4.2/src/x11.rs:59:28:
Library libxkbcommon-x11.so could not be loaded.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
An unrecoverable error occured. Error details: Library libxkbcommon-x11.so could not be loaded.

@kira-bruneau
Copy link
Contributor Author

Oh thanks for the heads up! I haven't been testing this on X11. It looks like the dependency was added in 0.10.1 -> 0.11.0: https://github.com/NiceneNerd/UKMM/pull/166/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR5764-R5775

@kira-bruneau
Copy link
Contributor Author

Sorry the first force push was from the wrong base commit and left off the update commit - it should be good now though!

Also switches from using LD_LIBRARY_PATH to RUSTFLAGS to include
required runtime libraries.
@symphorien symphorien merged commit a8e0343 into NixOS:master Jul 15, 2024
24 of 26 checks passed
@symphorien
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants