Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] voms: 2.1.0-rc2-unstable-2022-06-14 -> 2.1.0 #325097

Merged
merged 4 commits into from
Jul 7, 2024
Merged

[Backport release-24.05] voms: 2.1.0-rc2-unstable-2022-06-14 -> 2.1.0 #325097

merged 4 commits into from
Jul 7, 2024

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jul 6, 2024 •
edited
Loading

Description of changes

This pull request backports #270400 and bumps voms onto the latest official and stable release, 2.1.0. To do that, I backported its dependent commit 17ce994, normalizing name and version for non-officially released revision.

This pull request also backports #325116. It formats the code according to Nix RFC 166 and moves it under pkg/by-name to ease maintenance and future backports.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed; also see nixpkgs-review usage (It rebuilds some large packages such as root (CERN ROOT) and takes some time to run.)
  • Tested basic functionality of all binary files (usually in ./result/bin/) (voms --help and voms --version works. voms-proxy-init works and creates usable X509 user proxy on CERN LXPLUS.)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

wegank and others added 2 commits July 7, 2024 02:16
@wegank @ShamrockLee
voms: normalize pname and version
6c9a18b 
(cherry picked from commit 17ce994)
@ShamrockLee
voms: 2.1.0-rc2-unstable-2022-06-14 -> 2.1.0 (NixOS#270400)
bdf776d 
* voms: 2.1.0-rc2-unstable-2022-06-14 -> 2.1.0-rc3

* voms: 2.1.0-rc3 -> 2.1.0

(cherry picked from commit eb7805f)
@ShamrockLee ShamrockLee force-pushed the backport-voms-update branch from 2b53c08 to bdf776d Compare July 6, 2024 19:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jul 6, 2024
@ShamrockLee
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
40 packages built:
  • gfal2
  • gfal2-util (python311Packages.gfal2-util)
  • gfal2-util.dist (python311Packages.gfal2-util.dist)
  • hepmc3
  • htcondor
  • ns-3
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.fsspec-xrootd
  • python311Packages.fsspec-xrootd.dist
  • python311Packages.gfal2-python
  • python311Packages.gfal2-python.dist
  • python311Packages.hepmc3
  • python311Packages.snakemake-storage-plugin-xrootd
  • python311Packages.snakemake-storage-plugin-xrootd.dist
  • python311Packages.xrootd
  • python311Packages.xrootd.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • root
  • root.debug
  • voms
  • voms.bin
  • voms.dev
  • voms.etc
  • voms.man
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

@ShamrockLee ShamrockLee marked this pull request as ready for review July 6, 2024 20:39
@ShamrockLee
voms: format according to Nix RFC 166
8f090d7 
Format the code with nixfmt-rfc-style according to Nix RFC 166.

Add comment to elaborate the conditional output "etc" and to maipulate
the format.

(cherry picked from commit 027500a)
@ShamrockLee
voms: move to pkgs/by-name
e01566a 
(cherry picked from commit ea9855e)
@ShamrockLee
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
40 packages built:
  • gfal2
  • gfal2-util (python311Packages.gfal2-util)
  • gfal2-util.dist (python311Packages.gfal2-util.dist)
  • hepmc3
  • htcondor
  • ns-3
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.fsspec-xrootd
  • python311Packages.fsspec-xrootd.dist
  • python311Packages.gfal2-python
  • python311Packages.gfal2-python.dist
  • python311Packages.hepmc3
  • python311Packages.snakemake-storage-plugin-xrootd
  • python311Packages.snakemake-storage-plugin-xrootd.dist
  • python311Packages.xrootd
  • python311Packages.xrootd.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • root
  • root.debug
  • voms
  • voms.bin
  • voms.dev
  • voms.etc
  • voms.man
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

@superherointj superherointj merged commit c28eaf8 into NixOS:release-24.05 Jul 7, 2024
25 checks passed
@ShamrockLee ShamrockLee deleted the backport-voms-update branch July 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShamrockLee @superherointj @wegank