Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_1_0_2: 1.0.2m -> 1.0.2n (CVE-2017-3737, CVE-2017-3738) #32507

Merged
merged 1 commit into from
Dec 9, 2017
Merged

openssl_1_0_2: 1.0.2m -> 1.0.2n (CVE-2017-3737, CVE-2017-3738) #32507

merged 1 commit into from
Dec 9, 2017

Conversation

andir
Copy link
Member

@andir andir commented Dec 9, 2017

Motivation for this change

https://www.openssl.org/news/secadv/20171207.txt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir andir mentioned this pull request Dec 9, 2017
Closed
46 tasks
@orivej
Copy link
Contributor

orivej commented Dec 9, 2017

The commit message is wrong, it declares a downgrade. Please rebase onto staging.

@andir andir changed the base branch from master to staging December 9, 2017 12:13
@andir andir changed the title openssl_1_0_2: 1.0.2n -> 1.0.2.m (CVE-2017-3737, CVE-2017-3738) openssl_1_0_2: 1.0.2m -> 1.0.2n (CVE-2017-3737, CVE-2017-3738) Dec 9, 2017
@andir
Copy link
Member Author

andir commented Dec 9, 2017

@orivej sorry for that. Rebased onto staging and reworded.

@orivej orivej merged commit 87317ba into NixOS:staging Dec 9, 2017
@orivej orivej added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 9, 2017
@ttuegel ttuegel removed their request for review December 9, 2017 14:15
vcunat pushed a commit that referenced this pull request Dec 10, 2017
@orivej @vcunat
Merge #32507: openssl_1_0_2: 1.0.2m -> 1.0.2n
cfc4fcf 
security fixes: CVE-2017-3737, CVE-2017-3738

(cherry picked from commit 87317ba)
@orivej orivej added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andir @orivej @GrahamcOfBorg