-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulkan-headers,vulkan-loader: 1.3.283.0 -> 1.3.289 #325038
Conversation
Have you considered migrating them to by-name? |
Won't the automatic migration take care of that? I thought we weren't supposed to migrate manually. |
Technically it is allowed to migrate them manually, but only during update PRs or fixing other stuff. |
The manual migration is allowed in a PR in which another modification takes place. Besides it, the mere migration of files is not recommended. |
Usually we try to keep the whole Vulkan SDK family in sync, e.g. #281591 |
I was just informed about the vulkan version tagging scheme. This PR updates vulkan to a regular release, not a SDK. Is that fine or should we wait? |
Given the mass-rebuild, I would wait. |
Makes sense, closing. |
Description of changes
Prerequisite for packaging vulkan-enabled skia 124, which is itself a prerequisite for updating ladybird, which I maintain
edit: this wasn't actually needed. I have no idea why I thought it was, maybe I confused a different vulkan error
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.