greetd.dlm: correct cargo dependencies #324316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cargoSha256 is actually wrong as Cargo.lock contains git dependencies.
ofborg
bot
added
10.rebuild-darwin: 0
Aleksanaa
added a commit
to Aleksanaa/nixpkgs
that referenced
this pull request
Jul 15, 2024
I found this package while cleaning cargoSha256. Its cargoSha256 was actually wrong and included git dependencies, but it has never been corrected. I tried fixing it in NixOS#324316 and requested a maintainer review, but the maintainer didn't respond to me for the next two weeks. Upstream was last updated four years ago. Considering we now have much better login managers for greetd, we should no longer need this package.
shahinism
pushed a commit
to shahinism/nixpkgs
that referenced
this pull request
Jul 15, 2024
I found this package while cleaning cargoSha256. Its cargoSha256 was actually wrong and included git dependencies, but it has never been corrected. I tried fixing it in NixOS#324316 and requested a maintainer review, but the maintainer didn't respond to me for the next two weeks. Upstream was last updated four years ago. Considering we now have much better login managers for greetd, we should no longer need this package.
mindstorms6
pushed a commit
to mindstorms6/nixpkgs
that referenced
this pull request
Aug 15, 2024
I found this package while cleaning cargoSha256. Its cargoSha256 was actually wrong and included git dependencies, but it has never been corrected. I tried fixing it in NixOS#324316 and requested a maintainer review, but the maintainer didn't respond to me for the next two weeks. Upstream was last updated four years ago. Considering we now have much better login managers for greetd, we should no longer need this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The cargoSha256 is actually wrong as Cargo.lock contains git dependencies.
This is found when dealing with the rest of #323983.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.