Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepsource: init at 0.8.6 #324286

Merged
merged 2 commits into from
Nov 3, 2024
Merged

deepsource: init at 0.8.6 #324286

merged 2 commits into from
Nov 3, 2024

Conversation

nipeharefa
Copy link
Contributor

@nipeharefa nipeharefa commented Jul 3, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nipeharefa nipeharefa force-pushed the deepsource branch 2 times, most recently from 8feb228 to c27c80c Compare July 3, 2024 10:54
@nipeharefa nipeharefa mentioned this pull request Jul 3, 2024
Open
13 tasks
FliegendeWurst
FliegendeWurst reviewed Oct 24, 2024
View reviewed changes
pkgs/by-name/de/deepsource/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/de/deepsource/package.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 24, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 24, 2024
Aleksanaa
Aleksanaa reviewed Nov 1, 2024
View reviewed changes
pkgs/by-name/de/deepsource/package.nix Show resolved Hide resolved
pkgs/by-name/de/deepsource/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/de/deepsource/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/de/deepsource/package.nix Outdated Show resolved Hide resolved
Aleksanaa
Aleksanaa reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have done all changes, squash/split into two commits only:

  1. maintainers: add nipeharefa
  2. deepsource: init at 0.8.6

@nipeharefa
Copy link
Contributor Author

done @Aleksanaa

@nipeharefa nipeharefa requested a review from Aleksanaa November 1, 2024 10:42
@nipeharefa nipeharefa force-pushed the deepsource branch 3 times, most recently from d52cf3f to 62e7398 Compare November 1, 2024 11:15
@Aleksanaa
Copy link
Member

done @Aleksanaa

Please check 62e7398

Also would be good to add a nixos.org/manual/nixpkgs/unstable#versioncheckhook if possible.

This is not added. Is it possible to do so?

@nipeharefa
Copy link
Contributor Author

oh okeey missing it @Aleksanaa

@nipeharefa
Copy link
Contributor Author

nipeharefa commented Nov 1, 2024 •
edited
Loading

oh okeey missing it @Aleksanaa

done. Please recheck @Aleksanaa

@Aleksanaa
Copy link
Member

done. Please recheck @Aleksanaa

Please check commit ac6b12b.

This commit contains changes from another one, and the order is wrong.

@nipeharefa nipeharefa force-pushed the deepsource branch 2 times, most recently from ac92027 to e6203a3 Compare November 2, 2024 08:28
Aleksanaa
Aleksanaa approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e6203a3

This is still not resolved. Do you need any help?

@nipeharefa
Copy link
Contributor Author

e6203a3

This is still not resolved. Do you need any help?
Hi @Aleksanaa , Did you mean that the commits are not in order or that the names in the maintainer list are not in order?

@Aleksanaa
Copy link
Member

I mean this commit ac356ed contains change from the other commit, and the order is wrong

@nipeharefa
Copy link
Contributor Author

I mean this commit ac356ed contains change from the other commit, and the order is wrong

Hi @Aleksanaa , I have pulled the latest changes from the master branch and ran the command

nix-instantiate --eval maintainers/scripts/check-maintainers-sorted.nix
"all good!"

is there anything else I need to adjust?

@Aleksanaa
Copy link
Member

Click on "Commits" on this page, and click on "maintainers: add nipeharefa", see what it contains. Also you have to add yourself to maintainers first, and then add the package, to avoid eval broken on one commit.

@nipeharefa
Copy link
Contributor Author

Click on "Commits" on this page, and click on "maintainers: add nipeharefa", see what it contains. Also you have to add yourself to maintainers first, and then add the package, to avoid eval broken on one commit.

Okay, could you please check again? The commits have been adjusted.

Aleksanaa
Aleksanaa reviewed Nov 2, 2024
View reviewed changes
pkgs/by-name/de/deepsource/package.nix Outdated
Comment on lines 14 to 17
nativeBuildInputs = [ installShellFiles ];
nativeInstallCheckInputs = [
versionCheckHook
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not wrong but weird. Could you put this after postInstall?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey, on it @Aleksanaa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Aleksanaa fixed, could you please check again?

Aleksanaa
Aleksanaa reviewed Nov 2, 2024
View reviewed changes
pkgs/by-name/de/deepsource/package.nix Outdated
pname = "deepsource";
version = "0.8.6";

nativeBuildInputs = [ installShellFiles ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this after src

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, @Aleksanaa fixed

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@Aleksanaa Aleksanaa merged commit 500a82d into NixOS:master Nov 3, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nipeharefa @Aleksanaa @FliegendeWurst @wegank