rustc: disable zerocallusedregs hardening flag on clang stdenv
#323668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-rustc-no-zerocallusedregs
branch
from
a4a9c52 to
b0f91d5
Compare
to reverse breakage due to it not being supported by clang when building for wasm32. really we should not be using a wrapped compiler to build for wasm, but that's a tangled knot..
risicle
force-pushed
the
ris-rustc-no-zerocallusedregs
branch
from
b0f91d5 to
4839263
Compare
risicle
changed the title
zerocallusedregs hardening flagzerocallusedregs hardening flag on clang stdenv
alyssais
approved these changes
Jun 30, 2024
wegank
added
the
12.approvals: 1
|
Uh, it would be nice if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Stopgap solution to #318674.
The real answer would be not to use a (host-platform-)wrapped compiler for building the wasm compiler builtins, but it looks like there's some weird stuff going on in the build process that needs further investigation - though all the time rustc is broken in staging-next on darwin, there are things that aren't getting tested properly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.