python3Packages.astropy: apply patch removing the usage of polyfill.io #323658
Conversation
ofborg
bot
added
11.by: package-maintainer
| postPatch = '' | ||
| substituteInPlace pyproject.toml \ | ||
| --replace-fail "numpy>=2.0.0" "numpy" | ||
| ''; |
There was a problem hiding this comment.
Not sure to understand why this removal is part of this change.
There was a problem hiding this comment.
Not sure to understand why this removal is part of this change.
You are right! It was a cherry-pick + merge conflict mistake.
LeSuisse
added
1.severity: security
`cdn.polyfill.io` is now considered to be a bad actor. https://sansec.io/research/polyfill-supply-chain-attack Disabled on more test that was flaky on my side.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-323658-to-release-24.05 origin/release-24.05
cd .worktree/backport-323658-to-release-24.05
git switch --create backport-323658-to-release-24.05
git cherry-pick -x abde345eca6de5a6dfa07cbc3cfda7dfd1a52648 |
|
A bit late... but the test change was also intentional? (given that the patch only changes docs if I read it right) |
|
Aish I didn't mean to push that test change :/, it was also part of my a bit careless |
|
Yup I confirm I had trouble with it when I tested on master. It might be because I was building on a quite loaded machine and the test seems to be timing sensitive. Also, @doronbehar do you want to handle the cherry-pick to stable or should I plan to do it? |
Yes please go ahead. |
Description of changes
Things done
nix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.