Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: 3.9.0 -> 3.9.1 #322663

Merged
merged 1 commit into from
Jul 4, 2024
Merged

gdal: 3.9.0 -> 3.9.1 #322663

merged 1 commit into from
Jul 4, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Jun 26, 2024

Description of changes

GDAL update to the latest patch version.

Release notes: https://github.com/OSGeo/gdal/blob/v3.9.1/NEWS.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jun 26, 2024
@imincik
Copy link
Contributor Author

imincik commented Jun 26, 2024

Result of nixpkgs-review pr 322663 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
13 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
129 packages built:
  • cloudcompare
  • entwine
  • gdal (python311Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • postgresql12JitPackages.postgis
  • postgresql12JitPackages.postgis.doc
  • postgresql12Packages.postgis
  • postgresql12Packages.postgis.doc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.gdal
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • t-rex
  • udig
  • vpv

@Artturin
Copy link
Member

I built python311Packages.morecantile,python311Packages.rio-tiler and they didn't fail

@Artturin
Copy link
Member

Check the ci passthru.tests fail

@vcunat
Copy link
Member

vcunat commented Jul 3, 2024 •
edited
Loading

This update fixes the build after staging-next #322145

=========================== short test summary info ============================
FAILED gcore/vsiaz.py::test_vsiaz_fake_write - TypeError: Failed expected string as 'msg' parameter, got 'int' instead.
Perhaps you meant to use a mark?
= 1 failed, 12560 passed, 1418 skipped, 6 deselected, 6 xfailed, 8 warnings in 872.99s (0:14:32) =

(at least if you fix the hash; python 3.11 -> 3.12 is probably the trigger)

vcunat
vcunat reviewed Jul 3, 2024
View reviewed changes
pkgs/development/libraries/gdal/default.nix Outdated
@@ -89,14 +88,6 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-xEekgF9GzsPYkwk7Nny9b1DMLTxBqTSdudYxaz4jl/c=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the hash?

hash = "sha256-WCTQHUU2WYYiliwCJ4PsbvJIOar9LmvXn/i5jJzTCtM=";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. you've been probably testing 3.9.0 with only the path named 3.9.1.

SuperSandro2000
SuperSandro2000 requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the hash

@vcunat vcunat changed the base branch from master to staging-next July 4, 2024 07:17
@vcunat vcunat merged commit 2f006bf into NixOS:staging-next Jul 4, 2024
10 of 11 checks passed
@vcunat
Copy link
Member

vcunat commented Jul 4, 2024 •
edited
Loading

We needed some gdal fix in staging-next, so I put this PR there early. Feel free to keep reviewing, improving, etc.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 4, 2024
@imincik
Copy link
Contributor Author

imincik commented Jul 4, 2024

@vcunat , sorry for not being responsive and thanks for the fix.

imincik added a commit to imincik/geospatial-nix that referenced this pull request Jul 4, 2024
@imincik
gdal: 3.9.0 -> 3.9.1
a457991 
Nixpkgs PR:
NixOS/nixpkgs#322663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@sikmir sikmir Awaiting requested review from sikmir

@nh2 nh2 Awaiting requested review from nh2

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@willcohen willcohen Awaiting requested review from willcohen

@nialov nialov Awaiting requested review from nialov

@l0b0 l0b0 Awaiting requested review from l0b0

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imincik @Artturin @vcunat @SuperSandro2000