pythonPackages.cffi: include patch to fix clang error #322614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes null-pointer-subtraction
|
Oh wow, I didn't realize how many packages depended on this. I have so far only confirmed that it builds, but both my NixOS and nix-darwin installations are still busy right now rebuilding what feels like 90% of packages... |
|
I can't build p11-kit so I can't test further. |
wegank
added
the
2.status: merge conflict
|
Supposedely #322388 has fixed this. I can currently not test, but I asume it has since that PR built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322191
Description of changes
Fixes null-pointer-subtraction error in Clang 13+.
This replaces the patch to originally suppress the warning with an actual upstream fix.
For some reasons this was needed on x86_64-darwin, as disabling the warning did not work there, see #322191
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.