Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.borb: adopt #322519

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jun 26, 2024

Description of changes

Diff: jorisschellekens/borb@refs/tags/v2.1.23...v2.1.24

Changelog: https://github.com/jorisschellekens/borb/releases/tag/v2.1.24

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 26, 2024
@getchoo getchoo added the 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers label Jul 15, 2024
@pbsds
Copy link
Member

pbsds commented Jul 19, 2024

Seems to break darwin

@getchoo
Copy link
Member Author

getchoo commented Jul 20, 2024

Looks like this bump already happened in #320924. This is only an adoption now

@getchoo getchoo changed the title python311Packages.borb: 2.1.23 -> 2.1.24; adopt python311Packages.borb: adopt Jul 20, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 20, 2024
@pbsds pbsds merged commit 5039db5 into NixOS:master Jul 21, 2024
29 checks passed
@getchoo getchoo deleted the pkgs/borb/adopt branch July 21, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants