Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.scipy: 1.13.1 -> 1.14.0 #322340

Merged
merged 1 commit into from
Jun 25, 2024
Merged

python312Packages.scipy: 1.13.1 -> 1.14.0 #322340

merged 1 commit into from
Jun 25, 2024

Conversation

doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@doronbehar doronbehar mentioned this pull request Jun 25, 2024
Merged
2 tasks
SuperSandro2000
SuperSandro2000 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test

@doronbehar
Copy link
Contributor Author

Thanks for the approval @SuperSandro2000. Do you have a Darwin machine at hand to test this? I'm asking because upstream's release notes mention Accelerate related changes to the Darwin build and I'm not sure if they are compiled right now out of the box.

@SuperSandro2000
Copy link
Member

Nope but Darwin on staging next is not fully working currently anyway

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 25, 2024
@doronbehar
Copy link
Contributor Author

OK hopefully a Darwin user will be able to add/fix that Accelerate feature when all the dependencies will be available.

@doronbehar doronbehar merged commit 5141ee3 into NixOS:staging-next Jun 25, 2024
29 of 30 checks passed
@doronbehar doronbehar deleted the pkg/scipy branch June 25, 2024 14:51
@vcunat
Copy link
Member

vcunat commented Jun 30, 2024

On *-darwin it complains

../scipy/meson.build:195:6: ERROR: Program or command 'xcrun' not found or not executable

/cc #322145; example: https://hydra.nixos.org/build/264606152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doronbehar @SuperSandro2000 @vcunat @wegank