binary: init at 0.3 #322087
Merged
binary: init at 0.3 #322087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getchoo
force-pushed
the
pkgs/binary/init
branch
from
5210875 to
1cac088
Compare
ofborg
bot
added
8.has: package (new)
getchoo
force-pushed
the
pkgs/binary/init
branch
from
1cac088 to
ac28727
Compare
pkgs/by-name/bi/binary/package.nix
Outdated
| python3Packages.buildPythonApplication rec { | ||
| pname = "binary"; | ||
| version = "0.3"; | ||
| pyproject = false; |
There was a problem hiding this comment.
Suggested change
| pyproject = false; | |
| format = "other"; |
There was a problem hiding this comment.
Nowadays we use pyproject = false.
Why did you suggest the opposite, @SuperSandro2000 ?
getchoo
force-pushed
the
pkgs/binary/init
branch
from
ac28727 to
a72c27f
Compare
AndersonTorres
approved these changes
Jun 25, 2024
Moraxyc
reviewed
Jun 28, 2024
Aleksanaa
reviewed
Jun 28, 2024
getchoo
force-pushed
the
pkgs/binary/init
branch
from
a72c27f to
0798139
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Binary is a small and simple app to convert numbers to a different base
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.