python311Packages.ffcv: fix tests #322042
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/packaging-a-python-library-with-c-distutils-extension/17732/5 |
|
Result of 2 packages built:
|
ofborg
bot
added
11.by: package-maintainer
wegank
added
the
12.approvals: 1
|
@samuela @SomeoneSerge Thanks for the reviews and feedback. I have made changes or responded to your comments if the changes were not possible. I've left some of the comments unresolved so you can see what I did and make sure it is satisfactory. |
|
Result of 2 packages built:
|
wegank
removed
the
12.approvals: 1
|
@samuela @SomeoneSerge all comments addressed |
SomeoneSerge
changed the title
|
Ah, I guess it's the commit names that ofborg looks at, not PR name; @djacu could you please update the commit message as per https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions? (if you browse through the "show all checks" you'll see that ofborg evaluated all outPaths but it skipped building ffcv |
Fixes python3Packages.ffcv tests by changing the directory in precheck. Cleaned up and refactored the derivation.
|
@SomeoneSerge TIL. I thought it was the PR title as well. I didn't see explicit guidance in that doc but it links to other documents about how the commit message should look. Like this one -> https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions Also, we should be able to trigger it manually but I agree that getting the commit message consistent with the contributing guide would be best. https://github.com/NixOS/ofborg?tab=readme-ov-file#build |
|
For python packages it ofborg does want the minor version of the package set specified too ( @ofborg build python3Packages.ffcv |
|
Hmm the guide is not clear what to do in cases other than init or version bumps. Is the init example a very specific example of a more generic capability? For example, the guide says for initial commits to write the commit message as |
|
Result of 2 packages built:
|
|
Looks like the And I'm wondering how/why the darwin builds run the tests when the linux builds don't. |
Description of changes
Fixes python3Packages.ffcv tests by changing the directory in precheck.
ffcvwas removed from python312Packages because it does not successfully build due to a dependency on distutils. Looks like they have a version 1.1.0 branch in the works that removes that but it has not been released yet.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.