Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.safe-exceptions: fix strictDeps build #322008

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

erdnaxe
Copy link
Member

@erdnaxe erdnaxe commented Jun 23, 2024

Description of changes

Motivation: #178468

Without this patch, a build with config.strictDepsByDefault = true fails with ghc-9.6.5: could not execute: hspec-discover.

I never touched the Haskell packages ecosystem before, so I might have done something wrong.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erdnaxe erdnaxe force-pushed the safe-exceptions-strictdeps branch from 9cc6931 to 7a36582 Compare June 24, 2024 18:41
@maralorn maralorn marked this pull request as draft July 4, 2024 12:40
@maralorn maralorn changed the base branch from staging to haskell-updates July 4, 2024 12:41
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: golang 6.topic: vim 6.topic: ocaml 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: stdenv Standard environment 6.topic: nodejs labels Jul 4, 2024
@github-actions github-actions bot added 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Jul 4, 2024
@maralorn maralorn changed the base branch from haskell-updates to staging July 4, 2024 12:41
@github-actions github-actions bot removed 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: golang 6.topic: vim 6.topic: ocaml 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Jul 4, 2024
@maralorn maralorn marked this pull request as ready for review July 4, 2024 12:41
@maralorn maralorn merged commit 8f269a9 into NixOS:staging Jul 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants