miru: darwin support, add maintainer #321539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-pacini
force-pushed
the
miru-darwin
branch
from
ace7335 to
3947bb0
Compare
d4ilyrun
reviewed
Jun 21, 2024
d4ilyrun
approved these changes
Jun 21, 2024
ofborg
bot
added
11.by: package-maintainer
matteo-pacini
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1768 |
|
Result of 1 package built:
|
DontEatOreo
approved these changes
Jun 23, 2024
wegank
added
12.approvals: 2
wegank
reviewed
Jun 23, 2024
pkgs/by-name/mi/miru/darwin.nix
Outdated
Comment on lines
20
to
32
| nativeBuildInputs = [ unzip ]; | ||
|
|
||
| installPhase = '' | ||
| mkdir -p $out/{bin,Applications} | ||
| cp -r Miru.app $out/Applications/ | ||
| ln -s $out/Applications/Miru.app/Contents/MacOS/Miru $out/bin/miru | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ unzip ]; | |
| installPhase = '' | |
| mkdir -p $out/{bin,Applications} | |
| cp -r Miru.app $out/Applications/ | |
| ln -s $out/Applications/Miru.app/Contents/MacOS/Miru $out/bin/miru | |
| ''; | |
| nativeBuildInputs = [ | |
| unzip | |
| makeWrapper | |
| ]; | |
| installPhase = '' | |
| runHook preInstall | |
| mkdir -p $out/{bin,Applications} | |
| cp -r Miru.app $out/Applications/ | |
| makeWrapper $out/Applications/Miru.app/Contents/MacOS/Miru $out/bin/miru | |
| runHook postInstall | |
| ''; |
$out/bin/miru won't work as expected when created with ln -s.
matteo-pacini
force-pushed
the
miru-darwin
branch
from
3947bb0 to
50831cf
Compare
matteo-pacini
force-pushed
the
miru-darwin
branch
from
50831cf to
45cfa86
Compare
|
@wegank addressed your comments, and tested out "$out/bin/miru", works perfectly, thanks for the suggestion. Ready for re-review 🙏🏻 |
wegank
removed
the
12.approvals: 2
|
Result of 1 package built:
|
DontEatOreo
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
linuxanddarwinlinuxas it is, and added relevant code fordarwinThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.