-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loopwm: init at 1.0.0 #321219
loopwm: init at 1.0.0 #321219
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4132 |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afh I think it's SIP flagging the app, as Nix sets all file dates to 1 second after Epoch. Happens to me with all pre-compiled apps, and the only way to fix it is to navigate to Settings -> Privacy and Security, scroll down the list, find the app rejection, and tap on "Open Anyway". You will get again a warning prompt, but this time you should have an option to actually open the app. EDIT: This steps I do work on |
@afh Thanks for the feedback also, an update has been pushed. Ready for re-review 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the review suggestions and providing helpful context on the error I observed. 👍
Find below a comemnt about a minor nit that might be worthwhile to address in case you wanted to go above and beyond with this PR.
@afh I'm all-in for good-practices, thanks for the feedback, ready for re-review 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @matteo-pacini! 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1772 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1779 |
Successfully created backport PR for |
Description of changes
Added
loopwm
(Loop window manager) for*-darwin
, to distinguish it from the packageloop
.Description from the repo:
Loop is a macOS app that simplifies window management for you! You can effortlessly choose your window direction using a radial menu triggered by a simple key press, and customize it according to your preferences with personalized colors and settings. You can easily move, resize, and arrange your windows with just a few clicks, saving you valuable time and energy.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.