Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepassxc: 2.7.8 -> 2.7.9 #321178

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/keepassxc/versions.

meta.description for keepassxc is: Offline password manager with many features

meta.homepage for keepassxc is: https://keepassxc.org/

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 2.7.9 with grep in /nix/store/1cyg9wcc1ndarp6vvxxz0vxk6a9v9nbz-keepassxc-2.7.9
  • found 2.7.9 in filename of file in /nix/store/1cyg9wcc1ndarp6vvxxz0vxk6a9v9nbz-keepassxc-2.7.9

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

keepassxc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/1cyg9wcc1ndarp6vvxxz0vxk6a9v9nbz-keepassxc-2.7.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A keepassxc https://github.com/r-ryantm/nixpkgs/archive/e6b0f860eb7214a41c84e59b24066751894d1e26.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e6b0f860eb7214a41c84e59b24066751894d1e26#keepassxc

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/1cyg9wcc1ndarp6vvxxz0vxk6a9v9nbz-keepassxc-2.7.9
ls -la /nix/store/1cyg9wcc1ndarp6vvxxz0vxk6a9v9nbz-keepassxc-2.7.9/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • keepassxc

Maintainer pings

cc @jonafato @BlankParticle for testing.

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 321178 run on aarch64-darwin 1

1 package built:
  • keepassxc

LGTM

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 321178 run on x86_64-linux 1

1 package built:
  • keepassxc

@JohnRTitor JohnRTitor merged commit 831e75e into NixOS:master Jun 20, 2024
31 checks passed
@r-ryantm r-ryantm deleted the auto-update/keepassxc branch June 21, 2024 00:21
@hpfr
Copy link

hpfr commented Jun 28, 2024

Could this be backported to 24.05? It’s a patch release and there have been a number of fixes since 2.7.7

@JohnRTitor JohnRTitor added the backport release-24.05 Backport PR automatically label Jun 28, 2024
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-321178-to-release-24.05 origin/release-24.05
cd .worktree/backport-321178-to-release-24.05
git switch --create backport-321178-to-release-24.05
git cherry-pick -x e6b0f860eb7214a41c84e59b24066751894d1e26

@JohnRTitor
Copy link
Contributor

Could this be backported to 24.05? It’s a patch release and there have been a number of fixes since 2.7.7

PRs welcomed.

@hpfr
Copy link

hpfr commented Aug 10, 2024

PRs welcomed.

I forgot I could just pull in the newer package with a nixpkgs-unstable overlay. Since this is a “leaf application”, that seems easier than burdening maintainers with backport PRs. Sorry for the noise!

@bjornfor bjornfor added backport release-24.05 Backport PR automatically and removed backport release-24.05 Backport PR automatically labels Oct 20, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants