Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/scripts/update: support skipping prompts #319860

Merged
merged 1 commit into from
Jul 12, 2024
Merged

maintainers/scripts/update: support skipping prompts #319860

merged 1 commit into from
Jul 12, 2024

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Jun 14, 2024 •
edited
Loading

maintainers/scripts/update.py: support skipping prompts

Useful for not having to press ENTER for continuing execution.

To test:

nix-shell maintainers/scripts/update.nix --argstr package bicep --argstr skip-prompt true

Found a new solution that works:

yes '' | nix-shell maintainers/scripts/update.nix --argstr package bicep

This clever solution might not be obvious to everyone. The argument is obvious.

@superherointj superherointj requested a review from jtojnar as a code owner June 14, 2024 17:14
@superherointj superherointj mentioned this pull request Jun 14, 2024
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 14, 2024
ulrikstrid
ulrikstrid approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@ulrikstrid ulrikstrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an area of the repo I'm super familiar with but the change looks reasonable

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 14, 2024
@superherointj superherointj merged commit 61ff097 into NixOS:master Jul 12, 2024
36 checks passed
@superherointj superherointj deleted the update-script-skip-prompt branch July 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@viraptor viraptor Awaiting requested review from viraptor

@roberth roberth Awaiting requested review from roberth

@romildo romildo Awaiting requested review from romildo

@alyssais alyssais Awaiting requested review from alyssais

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superherointj @ulrikstrid @AndersonTorres @wegank