-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lisp-modules: Add coalton #319688
lisp-modules: Add coalton #319688
Conversation
Upstream explicitly fixes compatibility with the newest SBCL
b39bc36
to
28e2d04
Compare
Thank you very much for doing this. I wanted to look at coalton for a long time and this makes it easier. But I do get stuck on testing this:
Any idea what I am doing wrong ? |
@nagy * (load "expr.lisp")
* (in-package #:coalton-user)
* (coalton-toplevel (define (square x) (E* x x)))
* (coalton (dt (E+ (square (EVar t)) (Econst 1))))
#.(E+ #.(E+ #.(E* #.(ECONST 1) #.(EVAR :|t|)) #.(E* #.(EVAR :|t|) #.(ECONST 1))) #.(ECONST 0))
* (type-of 'square)
∀ :A. ((EXPR :A) → (EXPR :A)) Thanks for checking it out, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, that has worked thanks. We just have to keep an eye on these overrides, that once we update the quicklisp distributions, that they do not cause problems. But otherwise it looks great. Thanks again for the package.
You're welcome, cheers, thanks for the aproove. |
@ofborg build nyxt |
Description of changes
Add the coalton functional typesystem library for Common Lisp.
Happens to also need fset, so #318943 gets solved I think?
And fset needed a newer misc-extensions, since the one from QuickLisp didn't provide the constant symbol in GMap which fset uses.
FSet is probably a big breaking update: https://github.com/slburson/fset/releases/tag/v1.4.0
With misc-extensions I'm not sure, they don't seem to have a comprehensive list anywhere, but it doesn't look like there's anything being taken out.
Sorry for the ping, I didn't realize nyxt references self and so would be affected by the fset update.
I moved the rev in cl-gobject-introspection to the commit that explicitly fixed the change in SBCL, this should've probably been another pull request, but I wanted to make sure none of these changes broke nyxt in the end, so it now compiles and runs.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.