ocamlPackages.memprof-limits: init at 0.2.1

[Alizter]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[vbgl]

This does not build with OCaml 5.2. It might be nice to throw an evaluation-time error.

[Alizter]

Yes, it seems we need to restrict < 5.0.

[Alizter]

@vbgl I've added a check. Do you think it would be better if we introduced maximalOCamlVersion in buildDunePackage?

[vbgl]

Do you think it would be better if we introduced maximalOCamlVersion in buildDunePackage?

It sounds like a good idea. In particular, this would help avoiding silly mistakes such as swapping the arguments to versionAtLeast.

[Alizter]

Is it correct that our minimal ocaml version bound is strict?

[vbgl]

Please leave the refactoring of buildDunePackage as a separate PR.

[Alizter]

@vbgl OK, I'll put that in a separate PR then.

[vbgl]

While you’re at it, please double-check what happens to minimalOCamlVersion and the like (i.e., arguments that are intended for dune wrapper and not for the underlying mkDerivation).

[Alizter]

I've dropped the commit touching buildDunePackage (I'll handle that in another PR) and updated the version check. I am using versionOlder and the arguments should be in the correct order this time.