Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-cmdb: init at 1.31, python3Packages.jsonxs: init at 0.6 #317405

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

tie
Copy link
Member

@tie tie commented Jun 5, 2024

Description of changes

Packages http://github.com/fboender/ansible-cmdb

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tie
Copy link
Member Author

tie commented Jun 5, 2024

Result of nixpkgs-review pr 317405 run on aarch64-linux 1

6 packages built:
  • ansible-cmdb
  • ansible-cmdb.dist
  • python311Packages.jsonxs
  • python311Packages.jsonxs.dist
  • python312Packages.jsonxs
  • python312Packages.jsonxs.dist

@tie tie marked this pull request as ready for review June 5, 2024 10:16
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 5, 2024
@felbinger
Copy link
Member

felbinger commented Jun 6, 2024

I got some comments earlier that the pr titel and commits should include python3Packages., so I suggest updating your pr title to: python3Packages.jsonxs: init at 0.6; python3Packages.ansible-cmdb: init at 1.31 and you'r second commit to python3Packages.ansible-cmdb: init at 1.31

@felbinger
Copy link
Member

It can also be build on x86_64-linux

Result of nixpkgs-review pr 317405 run on x86_64-linux 1

6 packages built:
  • ansible-cmdb
  • ansible-cmdb.dist
  • python311Packages.jsonxs
  • python311Packages.jsonxs.dist
  • python312Packages.jsonxs
  • python312Packages.jsonxs.dist

@tie
Copy link
Member Author

tie commented Jun 6, 2024

I got some comments earlier that the pr titel and commits should include python3Packages., so I suggest updating your pr title to: python3Packages.jsonxs: init at 0.6; python3Packages.ansible-cmdb: init at 1.31 and you'r second commit to python3Packages.ansible-cmdb: init at 1.31

The ansible-cmdb package is not in the python3Packages package set (it’s an application, not python package), so it shouldn’t be prefixed. W.r.t. PR title, it’s the first time I’m hearing about this convention and I don’t think it’d scale to a more complex change sets, but I guess it’s fine since there are only two small init commits.

@tie tie changed the title ansible-cmdb: init at 1.31 ansible-cmdb: init at 1.31, python3Packages.jsonxs: init at 0.6 Jun 6, 2024
@felbinger
Copy link
Member

I got some comments earlier that the pr titel and commits should include python3Packages., so I suggest updating your pr title to: python3Packages.jsonxs: init at 0.6; python3Packages.ansible-cmdb: init at 1.31 and you'r second commit to python3Packages.ansible-cmdb: init at 1.31

The ansible-cmdb package is not in the python3Packages package set (it’s an application, not python package), so it shouldn’t be prefixed. W.r.t. PR title, it’s the first time I’m hearing about this convention and I don’t think it’d scale to a more complex change sets, but I guess it’s fine since there are only two small init commits.

I see, my bad I oversaw this. I agree but I got these comments earlier on one of my pr's.

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally please format your files with nixfmt-rfc-style

pkgs/by-name/an/ansible-cmdb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/an/ansible-cmdb/package.nix Outdated Show resolved Hide resolved
@tie
Copy link
Member Author

tie commented Jun 30, 2024

Done.

@tie tie requested a review from JohnRTitor June 30, 2024 06:01
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 317405 run on x86_64-linux 1

6 packages built:
  • ansible-cmdb
  • ansible-cmdb.dist
  • python311Packages.jsonxs
  • python311Packages.jsonxs.dist
  • python312Packages.jsonxs
  • python312Packages.jsonxs.dist

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 757c5d5 into NixOS:master Jul 6, 2024
26 checks passed
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Successfully created backport PR for release-24.05:

@tie tie deleted the ansible-cmdb branch July 6, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants