-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-cmdb: init at 1.31, python3Packages.jsonxs: init at 0.6 #317405
Conversation
Result of 6 packages built:
|
I got some comments earlier that the pr titel and commits should include |
It can also be build on Result of 6 packages built:
|
The |
I see, my bad I oversaw this. I agree but I got these comments earlier on one of my pr's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally please format your files with nixfmt-rfc-style
Done. |
Result of 6 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully created backport PR for |
Description of changes
Packages http://github.com/fboender/ansible-cmdb
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.