antimatter-dimensions: init at 0-unstable-2024-05-11

[amozeo]

About package

Antimatter Dimensions is an idle incremental game with many prestige layers, and can take up to year to complete it.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

Result of nixpkgs-review pr 317242 run on x86_64-linux 1

1 package built:

• antimatter-dimensions

[Pandapip1]

Why bundle this as an electron app when you can have the desktop entry file run xdg-open index.html?

[JohnRTitor]

Why bundle this as an electron app when you can have the desktop entry file run xdg-open index.html?

Let's not go there. I'd be very much against a scenario where I installed an app and it opens in the web browser to run for god's sake.

[amozeo]

Why bundle this as an electron app when you can have the desktop entry file run xdg-open index.html?

Steam version of upstream is bundled with electron, and it's not available for linux unless you use proton.

[JohnRTitor]

You might also want to add a desktop file like

nixpkgs/pkgs/applications/editors/vscode/generic.nix

Lines 125 to 142 in a71e967

	desktopItem = makeDesktopItem {
	name = executableName;
	desktopName = longName;
	comment = "Code Editing. Redefined.";
	genericName = "Text Editor";
	exec = "${executableName} %F";
	icon = "vs${executableName}";
	startupNotify = true;
	startupWMClass = shortName;
	categories = [ "Utility" "TextEditor" "Development" "IDE" ];
	mimeTypes = [ "text/plain" "inode/directory" ];
	keywords = [ "vscode" ];
	actions.new-empty-window = {
	name = "New Empty Window";
	exec = "${executableName} --new-window %F";
	icon = "vs${executableName}";
	};
	};

[amozeo]

You might also want to add a desktop file like
@JohnRTitor

what's wrong with the way I currently made desktop icon?

[JohnRTitor]

I am not seeing a desktop file in /nix/store/xjz48hc4q7ijcxwbyxc330wqhqyjjvfs-antimatter-dimensions-0-unstable-2024-05-11/share/applications for some reason though.

[JohnRTitor]

LGTM