moreutils: minor packaging improvements #316446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `perl.withPackages` instead of manually wrapping. - plumb the docbook via `DOCBOOKXSL` instead of patching. - specify `INSTALL_BIN=install` instead of upstream's default `install -s`. this lets the user control stripping (via stdenv's `dontStrip` option), and notably in a way which is compatible with cross compilation (`install -s` is not).
uninsane
force-pushed
the
pr-moreutils-cleanup
branch
from
3076aea to
5c9bd5b
Compare
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
perl.withPackagesinstead of manually wrapping.DOCBOOKXSLinstead of patching.INSTALL_BIN=installinstead of upstream's defaultinstall -s. this lets the user control stripping (via stdenv'sdontStripoption), and notably in a way which is compatible with cross compilation (install -sis not).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.