Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.packages.ghc910: work around aarch64-darwin output cycles #316157

Merged
merged 1 commit into from
May 31, 2024
Merged

haskell.packages.ghc910: work around aarch64-darwin output cycles #316157

merged 1 commit into from
May 31, 2024

Conversation

sternenseemann
Copy link
Member

This ports our infamous patch for Cabal that prevents certain parts of the Paths_* module from being generated in order to prevent unnecessary references on aarch64-darwin, to GHC >= 9.10.

See also:

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sternenseemann
haskell.packages.ghc910: work around aarch64-darwin output cycles
3885dfe 
This ports our infamous patch for Cabal that prevents certain parts of
the Paths_* module from being generated in order to prevent unnecessary
references on aarch64-darwin, to GHC >= 9.10.

See also:

- Original issues: NixOS#140774
- Patches
  - Original patch for GHC >= 8.10 && < 9.2 / Cabal >= 3.2 && < 3.6:
    NixOS@b0dcd7f
  - Patch for GHC >= 9.2 && < 9.10 / Cabal >= 3.6 && < 3.12: NixOS#216857,
    NixOS@f6f780f129f50df536fb30,
    …
@sternenseemann sternenseemann mentioned this pull request May 31, 2024
Merged
6 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 31, 2024
@ofborg ofborg bot requested review from cdepillabout, expipiplus1 and guibou May 31, 2024 14:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 31, 2024
@sternenseemann sternenseemann merged commit fc1e809 into NixOS:haskell-updates May 31, 2024
25 checks passed
@sternenseemann sternenseemann deleted the ghc-9.10-darwin branch May 31, 2024 19:23
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@ncfavier ncfavier Awaiting requested review from ncfavier

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@guibou guibou Awaiting requested review from guibou

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sternenseemann