libgeotiff: 1.7.2 -> 1.7.3 #315042
Merged
libgeotiff: 1.7.2 -> 1.7.3 #315042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
Result of 4 packages marked as broken and skipped:
6 packages failed to build:
135 packages built:
|
|
Yes, I am aware of the fact that single small issue was fixed in this release. But, we should keep up-to-date |
Sorry, I should have written a bit more. I just wanted to link to the diff / commit list for the convenience of other reviewers, as
doesn't directly lead to a list of changes. I didn't mean to imply anything about these changes or whether we should bump the version or not. 🙈
Agreed! 🙂 I'm currently running |
das-g
approved these changes
May 30, 2024
There was a problem hiding this comment.
👍 change LGTM
👍 upstream changes LGTM, but probably don't matter for NixPkgs (or this package would be broken until this change is merged)?
👍 commit LGTM
✔️ built package with gh pr checkout 315042; nix build -f . libgeotiff
🤷 tried to test compilation of all packages that depend on this change using nix run nixpkgs#nixpkgs-review -- pr 315042, but that kept getting OOM-killed at some point 😞
Ship it!
l0b0
approved these changes
May 31, 2024
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
May 31, 2024
Nixpgks PR: NixOS/nixpkgs#315042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update libgeotiff to the latest patch version.
List of changes:
https://github.com/OSGeo/libgeotiff/releases/tag/1.7.3
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.