Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/applications: remove uneeded fetchpatch arguments #313271

Merged
merged 1 commit into from
May 21, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented May 21, 2024

Description of changes

This is a follow-up pr from the previous cleanup pr, since it did well:

This time I started remove unused fetchpatch arguments.
However, due to their higher count, I choose to split the pr into manageable parts, starting with pkgs/applications with a total of 70 files affected.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient force-pushed the remove-fetchpatch-pkgs-apps branch from 56069d4 to 0058552 Compare May 21, 2024 01:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 21, 2024
@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 21, 2024
@Sigmanificient Sigmanificient added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 21, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks clean, and ofborg eval passes.

@Aleksanaa Aleksanaa merged commit efb5313 into NixOS:master May 21, 2024
23 checks passed
@Sigmanificient Sigmanificient deleted the remove-fetchpatch-pkgs-apps branch May 21, 2024 12:37
@JohnRTitor JohnRTitor mentioned this pull request May 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants