Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.netbox-bgp: init at 0.14.0 #312861

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented May 19, 2024

Description of changes

NetBox plugin for BGP related objects documentation
https://github.com/netbox-community/netbox-bgp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felbinger
Copy link
Member Author

felbinger commented May 19, 2024

How can we handle minimal required netbox version?

Compatibility
NetBox 3.4 >= 0.9.0
NetBox 3.5 >= 0.10.0
NetBox 3.6 >= 0.11.0
NetBox 3.7 >= 0.12.0
NetBox 4.0 >= 0.13.2

Currently, I have chosen version 0.11.1 as the default to maintain compatibility with NetBox 3.6, which is the current stable version for nixos-23.11.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels May 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 19, 2024
@felbinger felbinger force-pushed the pkg-netbox-bgp branch 2 times, most recently from 7803a6d to a304b9a Compare May 22, 2024 09:50
@felbinger felbinger changed the title Init netbox-bgp at 0.11.1 netbox-bgp: init at 0.11.1 May 22, 2024
@felbinger felbinger changed the title netbox-bgp: init at 0.11.1 python311Packages.netbox-bgp: init at 0.11.1 May 22, 2024
@felbinger felbinger force-pushed the pkg-netbox-bgp branch 3 times, most recently from a5edd5c to a701132 Compare May 22, 2024 14:59
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 11, 2024
@felbinger felbinger requested a review from natsukium as a code owner July 10, 2024 21:40
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jul 10, 2024
@minijackson
Copy link
Member

@felbinger I think in terms of compatibility, you should choose whatever the netbox package is at, which is currently 3.7. Note that I've opened #331750 recently, so depending on which gets merged first, one of us will have to upgrade netbox-bgp.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@felbinger felbinger force-pushed the pkg-netbox-bgp branch 2 times, most recently from 15d9d2c to 64365d9 Compare October 3, 2024 15:44
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Oct 6, 2024
@felbinger felbinger force-pushed the pkg-netbox-bgp branch 4 times, most recently from 6ce4634 to 737db08 Compare October 19, 2024 17:40
@minijackson
Copy link
Member

The NetBox 4.1 upgrade was merged, so I think this plugin needs to be updated to v0.14.0

@felbinger felbinger changed the title python311Packages.netbox-bgp: init at 0.11.1 python311Packages.netbox-bgp: init at 0.14.0 Oct 26, 2024
@SuperSandro2000 SuperSandro2000 merged commit a48eed9 into NixOS:master Oct 26, 2024
32 of 33 checks passed
@felbinger felbinger deleted the pkg-netbox-bgp branch October 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants