Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.bsddb3: disable tests #310421

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 9, 2024

They require distutils, which has been removed in 3.12.

Closes: #308232

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

They require distutils, which has been removed in 3.12.

Closes: NixOS#308232
@mweinelt mweinelt merged commit 5c0c6e1 into NixOS:master May 10, 2024
25 of 26 checks passed
@mweinelt mweinelt deleted the bsddb3-tests branch May 10, 2024 13:36
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-310421-to-release-23.11 origin/release-23.11
cd .worktree/backport-310421-to-release-23.11
git switch --create backport-310421-to-release-23.11
git cherry-pick -x b7b5775f93524cf99e5eae6b99090ff25b13ff83

@AkechiShiro
Copy link
Contributor

Shouldn't we aim to fix upstream tests ? Or change to another dependency that has proper Python 3.12 support ?
Instead of disabling the tests ?

@AkechiShiro
Copy link
Contributor

See #308157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312packages.bsddb3
3 participants