Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keto: init at 0.13.0-alpha.0 #310141

Merged
merged 1 commit into from
May 13, 2024
Merged

keto: init at 0.13.0-alpha.0 #310141

merged 1 commit into from
May 13, 2024

Conversation

MrMebelMan
Copy link
Contributor

Description of changes

Add a new package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels May 8, 2024
pkgs/by-name/ke/keto/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/ke/keto/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/ke/keto/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/ke/keto/default.nix Outdated Show resolved Hide resolved
@DontEatOreo
Copy link
Member

pkgs/by-name automatically detects the package no need to add it to pkgs/top-level/all-packages.nix

@MrMebelMan MrMebelMan force-pushed the init/keto branch 2 times, most recently from c879299 to 87597c2 Compare May 8, 2024 16:22
@MrMebelMan
Copy link
Contributor Author

pkgs/by-name automatically detects the package no need to add it to pkgs/top-level/all-packages.nix

When I remove it from all-packages, I'm getting an error:
image

@MrMebelMan MrMebelMan force-pushed the init/keto branch 2 times, most recently from 1ac6dcd to d274fe5 Compare May 8, 2024 16:30
@DontEatOreo
Copy link
Member

You need to pass down the package name in the attr, so the command will be nix-build -A keto

@DontEatOreo
Copy link
Member

DontEatOreo commented May 8, 2024

The package in pkgs/by-name/ke/keto/ should be named package.nix instead of default.nix

@MrMebelMan
Copy link
Contributor Author

MrMebelMan commented May 8, 2024

@DontEatOreo when I rename it from default.nix to package.nix, the build crashes with

error: getting status of '/home/vlad/nixpkgs/pkgs/by-name/ke/keto/default.nix': No such file or directory

EDIT: everything's fine, my bad

@MrMebelMan
Copy link
Contributor Author

@DontEatOreo thanks!

@MrMebelMan MrMebelMan self-assigned this May 8, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 8, 2024
@prusnak
Copy link
Member

prusnak commented May 13, 2024

@GrahamcOfBorg build keto

@prusnak prusnak merged commit 83fc4bf into NixOS:master May 13, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants