Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua54Packages.lgi: mark as broken with Lua versions < 5.1 or >= 5.4 #309936

Merged
merged 1 commit into from
May 8, 2024

Conversation

kiike
Copy link
Member

@kiike kiike commented May 7, 2024

Description of changes

Add a patch to fix build with Lua 5.4, part of ZHF: #309482

cc: @NixOS/lua

Things done

Add patch and reference to merged PR that didn't make it to release yet.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike kiike added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 7, 2024
@kiike kiike requested a review from teto May 7, 2024 20:36
@teto
Copy link
Member

teto commented May 7, 2024

thank you for the PR. Since the PR mentions lua5.4 is "experimental" support so I would say instead of adding the patch, maybe mark it broken instead . It will make maintainance easier as well: meta.broken = luaOlder "5.1" || luaAtLeast "5.4";

@kiike
Copy link
Member Author

kiike commented May 8, 2024

thank you for the PR. Since the PR mentions lua5.4 is "experimental" support so I would say instead of adding the patch, maybe mark it broken instead . It will make maintainance easier as well: meta.broken = luaOlder "5.1" || luaAtLeast "5.4";

Makes absolute sense. Let me amend it.

EDIT: done!

@kiike kiike force-pushed the zhf/lua54pkgs/lgi branch from ca0c970 to 492d273 Compare May 8, 2024 08:20
@kiike kiike changed the title lua54Packages.lgi: fix build with Lua 5.4 lua54Packages.lgi: mark as broken with Lua versions < 5.1 or >= 5.4 May 8, 2024
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels May 8, 2024
@7c6f434c 7c6f434c merged commit 1b8a216 into NixOS:master May 8, 2024
27 of 28 checks passed
@teto
Copy link
Member

teto commented May 8, 2024

thanks for contributing to ZHF !

@kiike kiike deleted the zhf/lua54pkgs/lgi branch May 9, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: lua 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants