stackblur-go: init at 1.1.0 #309117
stackblur-go: init at 1.1.0 #309117
Conversation
ofborg
bot
added
8.has: package (new)
| meta = with lib; { | ||
| description = "A fast, almost Gaussian Blur implementation in Go"; | ||
| homepage = "https://github.com/esimov/stackblur-go"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ sodiboo ]; | ||
| mainProgram = "stackblur"; | ||
| }; |
There was a problem hiding this comment.
| meta = with lib; { | |
| description = "A fast, almost Gaussian Blur implementation in Go"; | |
| homepage = "https://github.com/esimov/stackblur-go"; | |
| license = licenses.mit; | |
| maintainers = with maintainers; [ sodiboo ]; | |
| mainProgram = "stackblur"; | |
| }; | |
| meta = { | |
| description = "A fast, almost Gaussian Blur implementation in Go"; | |
| homepage = "https://github.com/esimov/stackblur-go"; | |
| license = lib.licenses.mit; | |
| maintainers = with lib.maintainers; [ sodiboo ]; | |
| mainProgram = "stackblur"; | |
| }; |
The use of with lib; is discouraged. ref: #293767
You can put lib.licenses.mit in meta.license, and others too.
There was a problem hiding this comment.
Hm, i was vaguely aware of this being discouraged, but i had understood it as though nixpkgs encourages meta = with lib;, since i've seen a lot of packages do exactly that, including some i've worked on [1] [2].
In this case, i feel it's probably fine? it's obvious enough where licenses and maintainers comes from and there are literally no other identifiers within its scope (except sodiboo but that one is even more obvious). I could change it i guess, but it just feels like changing it for the sake of changing it?
There was a problem hiding this comment.
Thanks for your reply. I understand your opinion, meta in stackblur-go certainly only contains lib identifiers. However, I think meta can be extended to include other fields that can access other identifiers within its scope (e.g. meta.broken and meta.homepage, etc.), on the other hand meta.maintainers hardly contains them. Considering that other properties will be added in the future, I think using lib.licenses without with lib; contributes to long-term maintainability.
Although, to be honest, I have only recently read 293767 and started reviewing nixpkgs, so I may be misreading it, I feel the point that using with lib; for meta is too broad is a legitimate one.
Of course, more discussion is needed on whether these changes help the project, and I welcome your opinions.
There was a problem hiding this comment.
I've implemented the suggested changes in a recent commit.
| ldflags = [ "-s" "-w" ]; | ||
|
|
||
| meta = { | ||
| description = "A fast, almost Gaussian Blur implementation in Go"; |
There was a problem hiding this comment.
| description = "A fast, almost Gaussian Blur implementation in Go"; | |
| description = "Fast, almost Gaussian Blur implementation in Go"; |
| @@ -0,0 +1,32 @@ | |||
| { lib | |||
| , buildGoModule | |||
There was a problem hiding this comment.
Please format with the new formatter.
|
(these commits should probably be squash merged ) |
Yes, unfortunately we don't do squash merges. Please squash them yourself. |
|
i see. the commits have been squashed manually, and should now be ready to merge |
wegank
added
the
12.approvals: 3+
Description of changes
Adds https://github.com/esimov/stackblur-go.
This is a CLI program that implements the Stackblur algorithm.
I was gonna use it for a low-latency blur thing on my desktop, but benchmarking showed that it's not a significant improvement, so i don't actually use this? But i did package it for nixpkgs to test this. Generated mostly with
nix-initand the default exe name iscmd? I chosestackbluras a binary name (overstackblur-go) because that's what's shown in their README, and it doesn't coincide with anything else in nixpkgs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.