python312Packages.scrapy: fix test failure on Python 3.12 #308844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
scrapy-deltafetch is broken on py3.12 due to dependency on now-deprecated distutils, unrelated to this change Result of 2 packages failed to build:
14 packages built:
|
ofborg
bot
added
11.by: package-maintainer
|
With scrapy-deltafetch disabled on 3.12: Result of 14 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #308235
The current Scrapy release has 1 broken test on Python 3.12. This applies the commit from upstream that fixes the broken test as a patch.
Alternatively we could just ignore the test since the patch is changing the test's expectations - i.e. the behavior is correct, the test is wrong. If that's fine this can be closed in favor of #308157
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.