Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildPythonPackage, buildPythonApplication: make doCheck default less confusing #308377

Merged
merged 1 commit into from
Jul 3, 2024
Merged

buildPythonPackage, buildPythonApplication: make doCheck default less confusing #308377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/development/interpreters/python/mk-python-derivation.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ in

, meta ? {}

, doCheck ? config.doCheckByDefault or false
, doCheck ? true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit late now, but I think this fix was not the one that needed to happen, since doCheck never gets used.
Only attrs.doCheck is ever referenced, which doesn't need this line.

Suggested change
, doCheck ? true

Should we open another PR that just removes this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Removing this line from the set pattern is a better solution to such confusion.


, disabledTestPaths ? []

Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/interpreters/python/python2/mk-python-derivation.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@

, passthru ? {}

, doCheck ? config.doCheckByDefault or false
, doCheck ? true

, disabledTestPaths ? []

Expand Down