Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allure: modernize #307835

Merged
merged 1 commit into from
Apr 30, 2024
Merged

allure: modernize #307835

merged 1 commit into from
Apr 30, 2024

Conversation

afh
Copy link
Member

@afh afh commented Apr 29, 2024

Description of changes

  • Delete unsupported dontCheck attribute (see thread started by comment on #293498)
  • Add runHook p(re|ost)Install to installPhase
  • Simplify installPhase to reduce number of commands
  • Reformat longDescription onto multiple lines and make it read a bit nicer
  • Modernize package by
    • using finalAttrs
    • replacing src.sha256 with src.hash
    • removing superfluous use of pname
    • removing with lib from meta

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from happysalada April 29, 2024 21:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 29, 2024
@happysalada happysalada merged commit deda125 into NixOS:master Apr 30, 2024
26 of 27 checks passed
@afh afh deleted the modernize-allure branch July 19, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants