-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stduuid: fix cmake version #307320
Merged
Merged
stduuid: fix cmake version #307320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Apr 27, 2024
AndersonTorres
suggested changes
Apr 27, 2024
OlivierLDff
force-pushed
the
stduuid-version-fix
branch
from
April 27, 2024 23:25
19c676b
to
34a6703
Compare
OlivierLDff
force-pushed
the
stduuid-version-fix
branch
from
April 29, 2024 07:33
34a6703
to
0d5c42a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate this expression to by-name hierarchy:
- Move this
default.nix
file topkgs/by-name/st/stduuid/package.nix
; - Remove the line
stduuid = callPackage ../development/libraries/stduuid { };
frompkgs/top-level/all-packages.nix
. - Make a new commit with the two changes above (no need for a new PR).
stduuid reported the wrong version to cmake, causing `find_package(stduuid 1.2.3)` to fail (but `find_package(stduuid 1.0)` was working which is NOT expected. Patch is from this [PR](mariusbancila/stduuid#79). This will need to be updated if `stduuid` is getting maintained again one day.
OlivierLDff
force-pushed
the
stduuid-version-fix
branch
from
April 29, 2024 13:45
0d5c42a
to
9e5b4e9
Compare
AndersonTorres
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Migration to |
AndersonTorres
approved these changes
Apr 29, 2024
shlevy
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stduuid reported the wrong version to cmake, causing
find_package(stduuid 1.2.3)
to fail (butfind_package(stduuid 1.0)
was working which is NOT expected).Patch is from this PR.
This will need to be updated if
stduuid
is getting maintained again one day.Before it was
set(PACKAGE_VERSION "1.0")