-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib.warn: Use or behave like builtins.warn #306481
Conversation
Co-authored-by: Aleksana <[email protected]>
This aligns with Nix and makes it more readable. The prefix still stands out.
b4d7556
to
7d4a9a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is looking good to me, but the docs of the function need to be updated a bit.
- Bring up to date - Give meaning to the metavariables - Use italics for metavariables (just like the Nix manual) - Don't abbreviate - No hard feelings, Val.
Done:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Thanks! |
Weird to see the "Delete branch" button on somebody else's PR, instinctively clicked it, not sure if you want to keep it around :P |
Description of changes
Base
lib.warn
onbuiltins.warn
when available.Behave like it when it's not available.
Alternative to, and
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.