Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handheld-daemon-ui: init at 3.2.3 #305027

Merged
merged 10 commits into from
Nov 19, 2024
Merged

handheld-daemon-ui: init at 3.2.3 #305027

merged 10 commits into from
Nov 19, 2024

Conversation

toast003
Copy link
Contributor

Description of changes

New package: https://github.com/hhd-dev/hhd-ui/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 18, 2024
@appsforartists
Copy link
Contributor

Was surprised to see an AppImage and did some digging:

@toast003
Copy link
Contributor Author

Not familiar with building npm/electron stuff from source and looking at the pr it seems kinda complicated, but I'll try and see if I can get it to work.

@toast003
Copy link
Contributor Author

toast003 commented Apr 18, 2024 •
edited
Loading

I can't get this to build from source

EDIT: Yeah, I give up.
Can we get this merged as-is?

@toast003 toast003 mentioned this pull request Apr 27, 2024
Merged
13 tasks
@toast003 toast003 mentioned this pull request Jul 8, 2024
Open
@toast003 toast003 changed the title handheld-daemon-ui: init at 2.2.3 handheld-daemon-ui: init at 3.1.1 Jul 8, 2024
@SuperSandro2000
Copy link
Member

I've dropped the merge commit from the PR because that usually only causes trouble.

@appsforartists
Copy link
Contributor

You probably also want options.services.handheld-daemon.ui.enable to default to options.services.handheld-daemon.enable in nixos/modules/services/hardware/handheld-daemon.nix, and pull this package in when true.

@toast003
Copy link
Contributor Author

I wanted to add that on a different pr, since you need to add handheld-daemon-ui and lsof to handheld-daemon's service path for the steam/gamescope overlay to work, but I guess it does make sense to have that here

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 10, 2024
@toast003 toast003 changed the title handheld-daemon-ui: init at 3.1.1 handheld-daemon-ui: init at 3.2.1 Oct 8, 2024
SuperSandro2000
SuperSandro2000 reviewed Oct 8, 2024
View reviewed changes
nixos/modules/services/hardware/handheld-daemon.nix Outdated
@@ -31,6 +40,11 @@ in

restartIfChanged = true;

path = mkIf cfg.ui.enable [
pkgs.handheld-daemon-ui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be wrapped inside the UI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally started a review instead of commenting so I'll post my comment again:

I'm not sure what you mean?

Handheld-daemon needs the ui to be in it's PATH, so I would need to wrap handheld-daemon, not the ui

@toast003
Copy link
Contributor Author

Changed some of the commit messages since the commits changing the module didn't start with nixos/

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 7, 2024
@toast003 toast003 changed the title handheld-daemon-ui: init at 3.2.1 handheld-daemon-ui: init at 3.2.3 Nov 15, 2024
@FliegendeWurst
Copy link
Member

I think it would also be good to squash the commits to one package and one nixos commit.

@appsforartists
Copy link
Contributor

Bummer that this is just barely missing 24.11.

@FliegendeWurst
Copy link
Member

New packages can almost always be backported :)

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@SuperSandro2000 SuperSandro2000 merged commit d5808ae into NixOS:master Nov 19, 2024
34 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@toast003 @github-actions
handheld-daemon-ui: init at 3.2.3 (#305027)
4e4781c 
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
(cherry picked from commit d5808ae)
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Closed
1 task
@appsforartists
Copy link
Contributor

🙌

I see the backport PR is targeting 24.05. Will it also open one for 24.11?

@SuperSandro2000 SuperSandro2000 added the backport release-24.11 Backport PR automatically label Nov 19, 2024
@SuperSandro2000
Copy link
Member

Ops, wrong label

@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@toast003 @github-actions
handheld-daemon-ui: init at 3.2.3 (#305027)
8be02ed 
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
(cherry picked from commit d5808ae)
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@toast003 @github-actions
handheld-daemon-ui: init at 3.2.3 (#305027)
1b54dff 
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
(cherry picked from commit d5808ae)
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
paschoal pushed a commit to paschoal/nixpkgs that referenced this pull request Nov 22, 2024
@toast003 @SuperSandro2000
@FliegendeWurst @paschoal
handheld-daemon-ui: init at 3.2.3 (NixOS#305027)
7f2abdb 
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
presto8 pushed a commit to presto8/nixpkgs that referenced this pull request Dec 3, 2024
@toast003 @presto8
handheld-daemon-ui: init at 3.2.3 (NixOS#305027)
91c6d3b 
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Arne Keller <[email protected]>
(cherry picked from commit d5808ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@appsforartists appsforartists appsforartists left review comments

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toast003 @appsforartists @SuperSandro2000 @FliegendeWurst @Aleksanaa @wegank