-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binutils 2.41 -> 2.42 #304035
binutils 2.41 -> 2.42 #304035
Conversation
This should target the staging branch because of the mass rebuild. |
The previous PR mentions a couple of needed fixes for 2.42 #283732 (comment). |
Could you rebase the PR by following the instructions in the CONTRIBUTING.md. I built a bunch of packages and a couple failed:
|
504f13a
to
b0f4baa
Compare
Okay, I think I changed it to the way it was described. Let me know if there's still something else that needs to be changed with that. |
It's still marked as draft @silvanshade perhaps you want to change that. Draft PRs can not be merged. |
cc. @trofi |
Looking at #283732 (comment)
|
Proposed |
I'm going to wait for both of the prereqs to land in master, then kick off a mass build and see what happens :) |
Those PRs are still in staging-next. But I think we can rebase this PR to the latest staging. |
b0f4baa
to
436931d
Compare
Rebased, kicking off the build |
Result of 16 packages built:
|
I'm going to try building up to the installer ISO now. |
Okay, I cherry-picked this branch on top of $ nix build --keep-going -f nixos/release-combined.nix nixos.iso_gnome.x86_64-linux Here is what I got:
I have uploaded it to https://binutils.cachix.org and pinned it: https://app.cachix.org/api/v1/cache/binutils/serve/h7p838lx3ys6z4ywdklqlgv8fswvrrbl/iso/nixos-gnome-24.11pre56789.gfedcba-x86_64-linux.iso If someone wants to try booting that into a VM, I'd appreciate it. I'm going to build the AArch64 image now |
436931d
to
9457845
Compare
Alright, the aarch64-linux build was successful, I've pushed it to cachix and pinned it: https://app.cachix.org/api/v1/cache/binutils/serve/bhgrm272wfmgdgfjf7i81njb3n6lwwy8/iso/nixos-gnome-24.11pre56789.gfedcba-aarch64-linux.iso |
Fingers crossed! |
Thanks all! |
Description of changes
This PR updates
binutils
to version2.42
.I removed two patches:
gold-powerpc-for-llvm.patch
: seems to be applied upstream0001-libtool.m4-update-macos-version-detection-block.patch
: doesn't apply; not clear if it's still neededThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)@Ericson2314 @lovesegfault