-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell-updates fixes: hevm #303658
haskell-updates fixes: hevm #303658
Conversation
Thank you. Can you follow the examples in configuration-common.nix and fetch this patch from GitHub with |
Oh, at the moment, there is no such patch as permanent link from github available. I think I found other examples who store patch under |
I haven’t heard about a patch link which can’t be made into a permanent one. What’s the issue, do you need a commit range? GitHub can do that. The guideline is: Avoid if sensibly possible. |
I didn't say it was not possible. I was just saying it was not there yet. I will create one in the right place. No problem
|
9b95635
to
c19855e
Compare
c19855e
to
2e67814
Compare
Updated the fixes, and now ready for reviewing:
CC @maralorn |
We prefer not to merge the base branch into pull requests, our git history is long enough as it is. |
Thank you! I will do the hourglass fix manually, since we need it on the branch now. The url to the hevm patch is unstable. Can you please change that to an explicit commit range? Also can you please add a comment to the upstream PR? |
I settled on a different fix for hourglass so you can remove your override from this PR. (after a rebase) |
Me again, sorry. I also applied the crypton-x509 fix on the branch, so you can also drop that. :D |
ab136bc
to
1f27e4c
Compare
okay, I just rebased instead. |
Ack, I have removed my fix. |
ack. |
1f27e4c
to
a152d99
Compare
Yes, that makes sense. Done.
It doesn't have an upstream PR for this minimum patch, though. I intend to create a PR with a bigger changeset. Is that okay? |
Sure. |
hash = "sha256-cL26HD77vXsiKqo5G6PXgK0q19MUGMwaNium5x93CBI="; | ||
})) | ||
(overrideCabal (old: { | ||
postPatch = old.pstPatch or "" + '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postPatch = old.pstPatch or "" + '' | |
postPatch = old.postPatch or "" + '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
a152d99
to
cccf2b3
Compare
Description of changes
I am fully aware the ongoing work at ethereum/hevm#471. But in the interest of unblocking hevm and its downstream packages. I made this fix for now, and I will monitor the upstream work and remove the patch when needed.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.