-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cope: remove #303596
cope: remove #303596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juding from how the upstream looks like, and a best-effort search on how many dependants this package has, removing it from nixpkgs makes a lot of sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on the approval of @msanft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even expanding the search, seems most of the usages of "cope" are in comments. Some of them are even commenting out cope
from their package lists.
And maintaining patches for a 10+ year old codebase is nontrivial.
|
With the comment above, I referred to out-of-tree consumers of nixpkgs using this package. However, no in-tree dependants are good as well :D |
Cope actually still works pretty well if it's patched for the warnings, I was running the warnings patch plus my own to make it use nixos's command-not-found. Applied this overlay for my version @ https://github.com/deftdawg/cope
Bummer to see it go from the official repo, I guess I'll have to roll it into a flake. |
Feel free to PR your changes here and add yourself as a maintainer then. I only skimmed copes sources and considered it worth a removal after having people run against that wall for about the 100th time in the last 12 months, just because cope has been the first result on the web search, CLI search, command-not-found, or nix-index for a given term. Keeping it the way it was, seemed to be more troublesome than removing it. Though I really do not know what warnings you are talking about. I only have seen hard errors with it… Running a cope-wrapped script always resulted in an error that exactly that command wasn't found. |
Description of changes
cope
upstream is a bunch of wrapper script, which require the same named binary to exist somewhere else inPATH
.This design barely works with nixpkgs, and fixing this would probably require a good amount of patching. It is also unclear if the nearly 10 year old wrappers still work for the modern variants of the wrapped tools.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.