-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avrdude: updates and enablement of compile-time features #303276
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3774 |
0277ef0
to
fece362
Compare
Testing it out on aarch64-darwin also. |
facd3e9
to
ec418b6
Compare
elfutils
or vendored libelf
instead of abandoned upstream
Sorry for the multiple pushes. I happened to get caught by #303244 doing the same thing as one of my commits. @bjornfor, @SuperSandro2000, I think this is ready for review now. |
@funkeleinhorn, as a user of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits look good. Didn't test.
ec418b6
to
b39d9e1
Compare
Thanks for the reviews @bjornfor and @SuperSandro2000. Updated per comments. |
b39d9e1
to
07b7ca8
Compare
I've squashed the two review commits into the initial ones. |
Description of changes
Sort of a smörgåsbord.
libelf
toelfutils
if possible; otherwise, use the vendored and slightly modified copy oflibelf
from https://github.com/avrdudes/libelf. See Switch most users from abandonedlibelf
toelfutils
#271473finalAttrs
instead ofrec
. See stdenv.mkDerivation: overlay style overridable recursive attributes #119942.libusb-compat-0_1
tolibusb1
as it appears to be compatible nowHAVE_LINUXGPIO
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)