Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: avoid setuid issues #303049

Merged
merged 3 commits into from
Apr 12, 2024
Merged

stdenv: avoid setuid issues #303049

merged 3 commits into from
Apr 12, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Apr 10, 2024

Maybe in time we'll have a better solution.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

See NixOS#300635.  Maybe in time we'll have a better solution.
This reverts commit e7df805
and 64cdda4.
@vcunat
Copy link
Member Author

vcunat commented Apr 10, 2024

I checked that plocate and lxc builds on x86_64-linux.

@adamcstephens
Copy link
Contributor

@ofborg build lxc.passthru.tests

@adamcstephens
Copy link
Contributor

The tests failed for seemingly unrelated reasons, but are a good way to validate that lxc will continue to work as expected.

@vcunat
Copy link
Member Author

vcunat commented Apr 10, 2024

This PR surely doesn't change the result of the lxc build.

@vcunat vcunat merged commit 993400a into NixOS:staging Apr 12, 2024
34 checks passed
@vcunat vcunat deleted the p/stdenv-setuid branch April 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants