nixos/matrix-synapse: don't use services.postgresql.initialScript in setup example
#302586
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
Ma27
force-pushed
the
synapse-initialscript-docs
branch
from
e8f6417 to
62f9486
Compare
…n setup example Closes NixOS#285688 This is misleading because `initialScript` will only be executed at the *very first* run of postgresql. I.e. when deploying synapse to a server with an existing postgresql, this won't work. We don't have a good way of automatically provisioning databases _declaratively_, so for now just explain what needs to be done here and leave it to the user how to include this into their deployment.
Ma27
force-pushed
the
synapse-initialscript-docs
branch
from
62f9486 to
a3d3cdf
Compare
|
Pushed a small wording change to make the first sentence of the new paragraph passive. |
|
We use ExecStartPre now to setup the database in our config, is this maybe something we also want to do in the upstream nixos module? |
|
In #80447 I regret it quite much that we had an automatic way of creating databases with no reasonable way to perform upgrades then. There are discussions about better approaches than ensure*-style options (#206467 and linked issues) and I hope we'll get there eventually. Until then my stance will be to have less of that magic. Feel free to file a patch or issue anyways if you disagree. That said, the effectively fixes a documentation bug, so I don't consider this blocking and I'd merge now. |
Description of changes
Closes #285688
This is misleading because
initialScriptwill only be executed at the very first run of postgresql. I.e. when deploying synapse to a server with an existing postgresql, this won't work.We don't have a good way of automatically provisioning databases declaratively, so for now just explain what needs to be done here and leave it to the user how to include this into their deployment.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.