spectral-language-server: init at 1.0.8 #301730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
|
Result of 1 package built:
|
|
@arduano @natsukium Would you review this pull request? 🙇 |
arduano
reviewed
Apr 8, 2024
|
Anyway the rest lgtm, but I'm new here, so I'll let more experienced contributors judge. Welcome to nixpkgs btw |
|
Thank you for your review! I'll be waiting for their judgement too. |
natsukium
requested changes
Apr 8, 2024
natsukium
reviewed
May 6, 2024
github-actions
bot
added
the
8.has: maintainer-list (update)
natsukium
reviewed
May 6, 2024
momeemt
force-pushed
the
spectral-language-server/init
branch
from
67e6513
to
dfc7069
Compare
|
@ofborg eval |
momeemt
force-pushed
the
spectral-language-server/init
branch
from
dfc7069
to
652444b
Compare
Co-authored-by: OTABI Tomoya <[email protected]>
momeemt
force-pushed
the
spectral-language-server/init
branch
from
652444b
to
ef0d7b7
Compare
natsukium
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #283363
Description of changes
spectral-language-server is a language server that includes Spectral, a flexible object linter with out-of-the-box support for OpenAPI v2 and v3, JSON Schema, and AsyncAPI.
I defined a derivation because #283363 requests this package.
https://github.com/luizcorreia/spectral-language-server
As this is my first time writing code on nixpkgs, I would be grateful if you could tell me if there are any bugs.
In particular, I'm wondering if my workaround for @rollup/pluginutils not providing type definitions for NodeNext is the right one.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.