Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freetube: 0.19.2 -> 0.20.0 #301533

Merged
merged 1 commit into from
Apr 5, 2024
Merged

freetube: 0.19.2 -> 0.20.0 #301533

merged 1 commit into from
Apr 5, 2024

Conversation

ozkutuk
Copy link
Contributor

@ozkutuk ozkutuk commented Apr 4, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from alyaeanyx and ryneeverett April 4, 2024 13:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 4, 2024
@fin444
Copy link
Contributor

fin444 commented Apr 4, 2024

Not a blocker on this PR specifically but just something to be advised of for the future of this package: #296939

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 5, 2024
@wegank wegank merged commit bbfb66e into NixOS:master Apr 5, 2024
27 of 28 checks passed
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants