Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typos: 1.20.1 -> 1.20.3 #301147

Merged
merged 1 commit into from
Apr 3, 2024
Merged

typos: 1.20.1 -> 1.20.3 #301147

merged 1 commit into from
Apr 3, 2024

Conversation

kachick
Copy link
Member

@kachick kachick commented Apr 3, 2024 •
edited
Loading

Diff: crate-ci/typos@v1.20.1...v1.20.3
Changelog: https://github.com/crate-ci/typos/blob/v1.20.3/CHANGELOG.md

Description of changes

Since 1.20.0, there were many false positive detections even after bumped to 1.20.1

Previous PR: #300834

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from mgttlinger and figsoda April 3, 2024 04:29
r-vdp
r-vdp approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@r-vdp r-vdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works fine, thanks!

@wegank wegank merged commit c079fb8 into NixOS:master Apr 3, 2024
30 of 31 checks passed
@kachick
Copy link
Member Author

kachick commented Apr 3, 2024

Thank you!

@kachick kachick deleted the update-typos-1.20.n branch April 3, 2024 08:33
@kachick kachick mentioned this pull request Apr 3, 2024
Merged
kachick added a commit to kachick/dotfiles that referenced this pull request Apr 4, 2024
@kachick
Add workaround for typos false positive detection
fccdc02 
 crate-ci/typos#973
NixOS/nixpkgs#301147
@kachick kachick mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vdp r-vdp r-vdp approved these changes

@mgttlinger mgttlinger Awaiting requested review from mgttlinger

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kachick @r-vdp @wegank